Closed
Bug 822366
Opened 12 years ago
Closed 11 years ago
Implement Mixed Content Blocker New Icon - Frontend Changes
Categories
(Firefox :: Security, defect)
Firefox
Security
Tracking
()
RESOLVED
FIXED
Firefox 21
People
(Reporter: tanvi, Assigned: tanvi)
References
(Blocks 1 open bug)
Details
Attachments
(2 files, 4 obsolete files)
1.48 KB,
image/png
|
Details | |
17.97 KB,
patch
|
tanvi
:
review+
|
Details | Diff | Splinter Review |
This bug is for the frontend changes needed for the Mixed Active Content Icon. The patch has already been reviewed and r+'ed (https://bugzilla.mozilla.org/attachment.cgi?id=689834&action=edit), so I'll carry that over to here. +++ This bug was initially created as a clone of Bug #782654 +++
Assignee | ||
Updated•12 years ago
|
Whiteboard: [leaveopen]
Assignee | ||
Comment 1•12 years ago
|
||
Carrying over patch and r+ from Dao in bug 782654.
Attachment #693103 -
Flags: review+
Comment 2•12 years ago
|
||
Comment on attachment 693103 [details] [diff] [review] Change Site Identity Icon for Mixed Active Content v5 Review of attachment 693103 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/themes/pinstripe/browser.css @@ +1361,5 @@ > #identity-box[open=true] > #page-proxy-favicon { > -moz-image-region: rect(0, 32px, 16px, 16px); > } > > @media (min-resolution: 2dppx) { Oops, this doesn't work on hi-dpi OS X -- you'll get http://cl.ly/image/161t2Z3m060Z. You need to to: * add a identity-icons-https-mixed-active@2x.png image that's twice the resolution + jar.mn entry * add an appropriate rule for it in this @media block
Assignee | ||
Comment 3•12 years ago
|
||
I'm adding a new patch that should fix the bug that Justin identified in comment 2. Except, that I need a 32x32 image of the mixed content triangle icon. For now, I have populated /browser/themes/pinstripe/identity-icons-https-mixed-active@2px.png with a copy of /browser/themes/pinstripe/identity-icons-https-mixed-active.png I'm going to mark this for review now in case there are any changes. I won't land until I have the new image and have updated /browser/themes/pinstripe/identity-icons-https-mixed-active@2px.png with it. Thanks!
Attachment #693103 -
Attachment is obsolete: true
Attachment #697717 -
Flags: review?(dao)
Flags: needinfo?(shorlander)
Comment 4•12 years ago
|
||
Comment on attachment 697717 [details] [diff] [review] Change Site Identity Icon for Mixed Active Content v6 Review of attachment 697717 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/themes/pinstripe/jar.mn @@ +33,5 @@ > skin/classic/browser/identity-icons-https@2x.png > skin/classic/browser/identity-icons-https-ev.png > skin/classic/browser/identity-icons-https-ev@2x.png > + skin/classic/browser/identity-icons-https-mixed-active.png > + skin/classic/browser/identity-icons-https-mixed-active@2px.png The suffix used on hidpi images is "@2x", not "@2px". The patch looks fine, otherwise.
Attachment #697717 -
Flags: review?(dao) → review-
Assignee | ||
Comment 5•12 years ago
|
||
(In reply to Justin Dolske [:Dolske] from comment #4) > Comment on attachment 697717 [details] [diff] [review] > Change Site Identity Icon for Mixed Active Content v6 > > Review of attachment 697717 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: browser/themes/pinstripe/jar.mn > @@ +33,5 @@ > > skin/classic/browser/identity-icons-https@2x.png > > skin/classic/browser/identity-icons-https-ev.png > > skin/classic/browser/identity-icons-https-ev@2x.png > > + skin/classic/browser/identity-icons-https-mixed-active.png > > + skin/classic/browser/identity-icons-https-mixed-active@2px.png > > The suffix used on hidpi images is "@2x", not "@2px". > > The patch looks fine, otherwise. Sorry, changed it to 2x. Now we just need the icon from Stephen.
Attachment #697717 -
Attachment is obsolete: true
Attachment #697816 -
Flags: review?(dolske)
Comment 6•12 years ago
|
||
Comment on attachment 697816 [details] [diff] [review] Change Site Identity Icon for Mixed Active Content v7 Looks good. (Well, I only looked at the tiny hidpi changes, so this is really r=dao)
Attachment #697816 -
Flags: review?(dolske) → review+
Comment 7•12 years ago
|
||
Here's a crudely-scaled version of the icons. 10 seconds of work. It would be ok to land with this to take the immediate pressure off our beloved shorlander. ;-) [If this happens, please file a followup to get true hidpi images in before final release.]
Comment 8•12 years ago
|
||
Attachment #697820 -
Attachment is obsolete: true
Flags: needinfo?(shorlander)
Assignee | ||
Comment 9•12 years ago
|
||
This incorporates Stephen's new icon. Dolske, can you test it?
Attachment #697816 -
Attachment is obsolete: true
Attachment #698022 -
Flags: review?(dolske)
Comment 10•12 years ago
|
||
Comment on attachment 698022 [details] [diff] [review] Change Site Identity Icon for Mixed Active Content v8 Yep, icon works properly in hidpi mode now.
Attachment #698022 -
Flags: review?(dolske)
Assignee | ||
Comment 11•12 years ago
|
||
Comment on attachment 698022 [details] [diff] [review] Change Site Identity Icon for Mixed Active Content v8 Carrying over r+.
Attachment #698022 -
Flags: review+
Assignee | ||
Comment 12•11 years ago
|
||
Pushed to inbound: http://hg.mozilla.org/integration/mozilla-inbound/rev/abba54950354
Updated•11 years ago
|
Hardware: x86 → All
Target Milestone: --- → Firefox 21
Comment 13•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/abba54950354
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•